Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2_control_node] add thread_priority option to the ros2_control_node (backport #1820) #1824

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[ros2_control_node] add thread_priority option to the ros2_control_node (backport #1820) #1824

merged 1 commit into from
Oct 31, 2024
+11 −2

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 30, 2024

Right now, the thread_priority is hard-coded to 50, this PR allows the users to be able to choose their desired priority by setting a parameter at launch time

ros2_control/controller_manager/src/ros2_control_node.cpp

Line 32 in b0da4a1

int const kSchedPriority = 50;

This is an automatic backport of pull request #1820 done by Mergify.

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 30, 2024

Cherry-pick of 832602d has failed:

On branch mergify/bp/humble/pr-1820
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 832602d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/ros2_control_node.cpp
	both modified:   doc/release_notes.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 30, 2024
@saikishor saikishor force-pushed the mergify/bp/humble/pr-1820 branch from 5c8a2bd to b6ab335 Compare October 31, 2024 08:34
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (1d67297) to head (b6ab335).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           humble    #1824      +/-   ##
==========================================
- Coverage   62.57%   62.55%   -0.02%     
==========================================
  Files         108      108              
  Lines       12024    12026       +2     
  Branches     8131     8132       +1     
==========================================
- Hits         7524     7523       -1     
- Misses        880      882       +2     
- Partials     3620     3621       +1
Flag Coverage Δ
unittests 62.55% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 80.00% <50.00%> (+1.21%) ⬆️

... and 1 file with indirect coverage changes

christophfroehlich
christophfroehlich approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are not related, see #1367

@christophfroehlich christophfroehlich merged commit d897740 into humble Oct 31, 2024
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1820 branch October 31, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor